[llvm-commits] [llvm] r91626 - in /llvm/trunk: lib/ExecutionEngine/JIT/JIT.cpp lib/ExecutionEngine/JIT/JIT.h lib/ExecutionEngine/JIT/JITEmitter.cpp unittests/ExecutionEngine/JIT/JITTest.cpp

[Jeffrey Yasskin]

Ok, committed as r91943. Sorry for the trouble. (I do have the same
reservations as Nick, but if we're going to break you, we should
_decide_ to break you, not do it accidentally. ;)

Also, FYI, the fix for http://llvm.org/PR5737 is probably going to
involve a change to the ModuleProvider interface. It'll still support
everything it supports today, but you'll probably have to create
Modules slightly differently. I'll try to remember to cc you on the
patch for that.

On Tue, Dec 22, 2009 at 2:45 PM, nicolas geoffray
<nicolas.geoffray at gmail.com> wrote:
> Yes! That patch works great for me!
> Thanks,
> Nicolas
>
> On Tue, Dec 22, 2009 at 8:52 PM, Jeffrey Yasskin <jyasskin at google.com>
> wrote:
>>
>> On Mon, Dec 21, 2009 at 9:38 PM, nicolas geoffray
>> <nicolas.geoffray at gmail.com> wrote:
>> > Hi Jeffrey,
>> >
>> >>
>> >> Ah, I see now. You have your own ModuleProvider, and it needs to know
>> >> precisely when the function is actually needed, right? Yeah, it sounds
>> >> like I need to roll back that part of this fix until PR5737 is fixed.
>> >>
>> >
>> > Yes, thanks!
>>
>> How's the attached patch look? I discovered that one of the
>> isDeclaration()s was untested, so I added a test for it.
>
>