[llvm-commits] [llvm] r91842 - /llvm/trunk/include/llvm/Support/Format.h

[Chris Lattner]

On Dec 22, 2009, at 1:34 AM, Anton Korobeynikov wrote:

> Hello, Daniel
> 
>> This broke the MSVC build, please take a look.
> I don't have vcpp around, but this patch unbreaks a mingw build (which
> was broken for quite long time). I explained, why it is incorrect
> regardless of compiler.
> 
> I'd really appreciate if someone with vcpp access look into this issue.
> Maybe we should do a #ifdef _MSC_VER, but this is still a hackish way to
> do things :(

Please restore the old code or check _MSC_VER, I don't care which.

> Note, that the most notable difference of snprintf and _snprintf is that
> the latter *does not* guarantee NULL termination!

The code in question doesn't care about this.

-Chris