[llvm-commits] [llvm] r91184 - in /llvm/trunk: lib/Transforms/Scalar/ScalarReplAggregates.cpp test/Transforms/ScalarRepl/2009-12-11-NeonTypes.ll

Eric Christopher echristo at apple.com
Sat Dec 19 00:19:12 PST 2009


On Dec 18, 2009, at 11:10 PM, Bob Wilson wrote:

>> The returned Idx should be a uint64_t for large indexes into large arrays.
> 
> OK.  I had considered that earlier but since SROA only handles small arrays I decided it didn't matter.  I guess you could have a nested aggregate where the inner array was too big to address with 32 bits.  I'm still not sure if it wouldn't have been better to check for large arrays and exclude them earlier, but it's not a big deal either way.

Been meaning to ask, for things like this would size_t be better? Things like vector, list, etc return size_t for size().

-eric



More information about the llvm-commits mailing list