[llvm-commits] [llvm] r91644 - /llvm/trunk/lib/Target/MSP430/AsmPrinter/MSP430MCInstLower.cpp

[John McCall]

Author: rjmccall
Date: Thu Dec 17 18:27:18 2009
New Revision: 91644

URL: http://llvm.org/viewvc/llvm-project?rev=91644&view=rev
Log:
Pass the error string directly to llvm_unreachable instead of the residual
(0 && "error").  Rough consensus seems to be that g++ *should* be diagnosing
this because the pointer makes it not an ICE in c++03.  Everyone agrees that
the current standard is silly and null-pointer-ness should not be based on
ICE-ness.  Excellent fight scene in Act II, denouement weak, two stars.


Modified:
    llvm/trunk/lib/Target/MSP430/AsmPrinter/MSP430MCInstLower.cpp

Modified: llvm/trunk/lib/Target/MSP430/AsmPrinter/MSP430MCInstLower.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/MSP430/AsmPrinter/MSP430MCInstLower.cpp?rev=91644&r1=91643&r2=91644&view=diff

==============================================================================
--- llvm/trunk/lib/Target/MSP430/AsmPrinter/MSP430MCInstLower.cpp (original)
+++ llvm/trunk/lib/Target/MSP430/AsmPrinter/MSP430MCInstLower.cpp Thu Dec 17 18:27:18 2009
@@ -34,7 +34,7 @@
   Mang.getNameWithPrefix(Name, GV, false);
 
   switch (MO.getTargetFlags()) {
-  default: llvm_unreachable(0 && "Unknown target flag on GV operand");
+  default: llvm_unreachable("Unknown target flag on GV operand");
   case 0: break;
   }