[llvm-commits] [Review] Preparing for non-power-of-2 machine value types in X86ISelLowering and LegalizeDAG

[Chris Lattner]

On Dec 16, 2009, at 7:33 AM, Ken Dyck wrote:

> The attached patches prepare for the introduction of non-power-of-2
> machine value types (as recently discussed [1]). They contain no
> functional changes. They merely eliminate assumptions that
> incrementing/decrementing a SimpleValueType doubles/halves its size and
> that all non-power-of-2 types are extended.

The change in LowerEXTRACT_VECTOR_ELT can be simplified: just force i32 there, that is the only valid valuetype for PEXTRW.

The legalize change looks reasonable to me, but please change the for loop to be a while loop (I think it will be clearer) and make it be a method on EVT instead of inline in the legalizer.

-Chris