[llvm-commits] [patch] fptr support for PPC64

Ken Werner ken at linux.vnet.ibm.com
Wed Dec 16 11:45:15 PST 2009


On Tuesday 15 December 2009 07:43:49 pm you wrote:
> On Dec 15, 2009, at 3:55 AMPST, Ken Werner wrote:
> > Hi,
> > The attached patch adds support for indirect calls (through function
> > pointer)
> > according to the ABI (http://refspecs.linuxfoundation.org/ELF/ppc64/PPC-
> > elf64abi-1.9.html#FUNC-CALLS). The patch was made against revision
> > 91275.
> I can't speak for SVR4 ppc64, but I'm confident these 3 patches won't  
> break any other target.
> 
> It's preferable to get isPPC64 from PPCSubTarget, as elsewhere  
> (inconsistently).  Here that seems to mean an extra parameter.
> Why did you add a Chain to PPCISD::NOP?
> Do you have write access?
The upated version of the patch obtains isPPC64 from PPCSubTarget and leaves 
the PPCISD::NOP without SDNPHasChain. I don't have commit privileges.
Thanks for reviewing the patch.
-ken
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ppc64-fptr.patch
Type: text/x-patch
Size: 8123 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20091216/5f3edece/attachment.bin>


More information about the llvm-commits mailing list