[llvm-commits] [llvm] r91397 - /llvm/trunk/lib/Analysis/ProfileInfo.cpp

[John McCall]

On Dec 14, 2009, at 9:46 PM, Chris Lattner wrote:

> 
> On Dec 14, 2009, at 6:35 PM, John McCall wrote:
> 
>> Author: rjmccall
>> Date: Mon Dec 14 20:35:24 2009
>> New Revision: 91397
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=91397&view=rev
>> Log:
>> You can't use typedefs to declare template member specializations, and
>> clang enforces it.
> 
> Does clang produce a good diagnostic (with a fixit hint) for this error?

We can't do the fixit hint yet because we don't track locations well enough in nested name specifiers.  This also means the caret is not necessarily helpful.

The diagnostic is
  error:  cannot use typedef 'ProfileInfo' (a.k.a. 'ProfileInfoT< llvm:: Function,llvm::BasicBlock>') in scope specifier for out-of-line declaration
which conveys the idea well enough, but is not exactly my finest diagnostic ever.

John.