[llvm-commits] [llvm] r90640 - /llvm/trunk/lib/Target/TargetData.cpp

[Bill Wendling]

On Dec 4, 2009, at 9:29 PM, Chris Lattner wrote:

> 
> On Dec 4, 2009, at 5:46 PM, Bill Wendling wrote:
> 
>> Author: void
>> Date: Fri Dec  4 19:46:01 2009
>> New Revision: 90640
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=90640&view=rev
>> Log:
>> Inline methods which are called only once.
> 
> Thanks Bill, a couple more things:
> 
> class StructLayoutMap : public AbstractTypeUser {
> public:
>  typedef DenseMap<const StructType*, StructLayout*> LayoutInfoTy;
> 
> no longer needs to be public.
> 
> 
> 
> 
>  virtual void refineAbstractType(const DerivedType *OldTy,
>                                  const Type *) {
>  virtual void typeBecameConcrete(const DerivedType *AbsTy) {
> ...
> 
> both of these can now just call InvalidateEntry.
> 
> 
> 
> const StructLayout *TargetData::getStructLayout(const StructType *Ty) const {
> 
> Please move the meat of this into StructLayoutMap, allowing the elimination of the operator[].
> 
> 
> Otherwise, looks very tidy now, thanks!
> 
Thanks. :) I'm doing it in waves because it broke last time. I'll get to the above soon.

-bw