[llvm-commits] [llvm] r90454 - /llvm/trunk/lib/Analysis/ProfileEstimatorPass.cpp

[Chris Lattner]

On Dec 3, 2009, at 5:34 AM, Andreas Neustifter wrote:

> Sorry, overlooked that on the buildbots.

Hi Andreas,

Instead of using pow(2, x) why not just use "1 << x", or better yet,  
just use the constant in this case?

-Chris

>
> Thanks, Andi
>
> On 12/03/2009 02:23 PM, Benjamin Kramer wrote:
>> Author: d0k
>> Date: Thu Dec  3 07:23:03 2009
>> New Revision: 90454
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=90454&view=rev
>> Log:
>> Fix MSVC build.
>>
>> Modified:
>>     llvm/trunk/lib/Analysis/ProfileEstimatorPass.cpp
>>
>> Modified: llvm/trunk/lib/Analysis/ProfileEstimatorPass.cpp
>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Analysis/ProfileEstimatorPass.cpp?rev=90454&r1=90453&r2=90454&view=diff
>>
>> = 
>> = 
>> = 
>> = 
>> = 
>> = 
>> = 
>> = 
>> = 
>> =====================================================================
>> --- llvm/trunk/lib/Analysis/ProfileEstimatorPass.cpp (original)
>> +++ llvm/trunk/lib/Analysis/ProfileEstimatorPass.cpp Thu Dec  3  
>> 07:23:03 2009
>> @@ -324,7 +324,7 @@
>>    // Since the entry block is the first one and has no  
>> predecessors, the edge
>>    // (0,entry) is inserted with the starting weight of 1.
>>    BasicBlock *entry =&F.getEntryBlock();
>> -  BlockInformation[&F][entry] = pow(2,32);
>> +  BlockInformation[&F][entry] = pow(2.0, 32.0);
>>    Edge edge = getEdge(0,entry);
>>    EdgeInformation[&F][edge] = BlockInformation[&F][entry];
>>    printEdgeWeight(edge);
>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits