[llvm-commits] [llvm] r90318 - in /llvm/trunk/lib/CodeGen/AsmPrinter: DIE.h DwarfDebug.cpp
Devang Patel
dpatel at apple.com
Wed Dec 2 07:25:16 PST 2009
Author: dpatel
Date: Wed Dec 2 09:25:16 2009
New Revision: 90318
URL: http://llvm.org/viewvc/llvm-project?rev=90318&view=rev
Log:
Clarify that DIEString does not keep a copy of the string.
Modified:
llvm/trunk/lib/CodeGen/AsmPrinter/DIE.h
llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp
Modified: llvm/trunk/lib/CodeGen/AsmPrinter/DIE.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/AsmPrinter/DIE.h?rev=90318&r1=90317&r2=90318&view=diff
==============================================================================
--- llvm/trunk/lib/CodeGen/AsmPrinter/DIE.h (original)
+++ llvm/trunk/lib/CodeGen/AsmPrinter/DIE.h Wed Dec 2 09:25:16 2009
@@ -274,7 +274,7 @@
};
//===--------------------------------------------------------------------===//
- /// DIEString - A string value DIE.
+ /// DIEString - A string value DIE. This DIE keeps string reference only.
///
class DIEString : public DIEValue {
const StringRef Str;
Modified: llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp?rev=90318&r1=90317&r2=90318&view=diff
==============================================================================
--- llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp (original)
+++ llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp Wed Dec 2 09:25:16 2009
@@ -330,8 +330,8 @@
Die->addValue(Attribute, Form, Value);
}
-/// addString - Add a string attribute data and value.
-///
+/// addString - Add a string attribute data and value. DIEString only
+/// keeps string reference.
void DwarfDebug::addString(DIE *Die, unsigned Attribute, unsigned Form,
const StringRef String) {
DIEValue *Value = new DIEString(String);
More information about the llvm-commits
mailing list