[llvm-commits] [llvm] r89017 - /llvm/trunk/lib/CodeGen/SelectionDAG/DAGCombiner.cpp

[Dan Gohman]

On Nov 22, 2009, at 7:03 AM, Chris Lattner wrote:

> 
> On Nov 16, 2009, at 4:47 PM, Dan Gohman wrote:
> 
>> Author: djg
>> Date: Mon Nov 16 18:47:23 2009
>> New Revision: 89017
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=89017&view=rev
>> Log:
>> Remove the optimizations that convert BRCOND and BR_CC into
>> unconditional branches or fallthroghes. Instcombine/SimplifyCFG
>> should be simplifying branches with known conditions.
>> 
>> This fixes some problems caused by these transformations not
>> updating the MachineBasicBlock CFG.
> 
> Did you verify that this change doesn't result in any codegen change on something large like 403.gcc?  It would also be useful to check something like crafty on x86-32 and ppc32.

I had checked a bunch of stuff, though not 403.gcc, and it turns out 403.gcc
had a missed ConstantExpr folding opportunity. I fixed that in r89659.

Dan