[llvm-commits] [llvm] r89951 - in /llvm/trunk: lib/Analysis/BasicAliasAnalysis.cpp lib/Target/README.txt test/Analysis/BasicAA/gep-alias.ll

[Chris Lattner]

On Nov 26, 2009, at 9:29 AM, Duncan Sands wrote:

> Hi Chris,
> 
>> +      Scale *= IndexScale.getZExtValue();
>> +      BaseOffs += IndexOffset.getZExtValue()*Scale;
> 
> shouldn't these two lines be swapped?  I think in the BaseOffs line
> you should be multiplying by the value of Scale before IndexScale was
> factored into it, not afterwards...

Nice catch, you're completely right, will fix!