[llvm-commits] [llvm] r89758 - in /llvm/trunk: lib/Transforms/Scalar/LoopUnswitch.cpp test/Transforms/LoopUnswitch/5373.ll

[Edward O'Callaghan]

G'day,

2009/11/24 Anton Korobeynikov <anton at korobeynikov.info>:
> Hello, Edward
>
>> Me, I tested it on my machine and everything seemed fine.
> How have you tested? Have you run llvm-gcc bootstrap and/or nightly tests, etc.?
> Fix of the testcase does not imply that change itself is correct
>

I did a fresh build of LLVM on auroraux and solaris with and without
the patch and ran the test case on both, when not patched llvm crashes
for me.

>> Thanks for the post-review,
> Sorry, I cannot review this patch. I don't feel competent enough to
> review commits for loop unswitch code.
>
> --
> With best regards, Anton Korobeynikov
> Faculty of Mathematics and Mechanics, Saint Petersburg State University
>
Cheers,
Edward.



-- 
--
Edward O'Callaghan
http://www.auroraux.org/
eocallaghan at auroraux dot org
---
()  ascii ribbon campaign - against html e-mail
/\                        - against microsoft attachments