[llvm-commits] [llvm] r88979 - /llvm/trunk/Makefile

Duncan Sands baldrick at free.fr
Mon Nov 23 02:54:14 PST 2009


Hi Daniel,

>>> Don't build examples by default, use BUILD_EXAMPLES=1 to build them. The
>>> only utility of this is testing that we keep the examples up to date, I will
>>> just make the buildbots run with this flag.
>> is this really a good idea?
> 
> Yes, I think so. I don't think the examples break that often.
> Additionally, developers changing APIs widely are already probably
> using grep or other tools to find the code to fix, and can always test
> the examples directly.
> 
>>  If someone breaks an example, wouldn't it be
>> better
>> for them to discover that directly themselves rather than via a buildbot?
> 
> No, this optimizes for the rare case (single developer, breaking
> single build) at the expensive of the extraordinarily common case
> (many many developers and buildbots, rebuilding llvm).

doesn't it just mean that breakage to examples won't be noticed for a long time,
and probably by some poor soul who was interested in giving LLVM a go, but now
won't because the examples don't even build...  Also, I had understood that the
builtbots would build the examples, but here you seem to suggest they won't?

Anyway, I'd be happier with this change if was possible to say "make all" and
have everything be built, examples and all, while "make" would build a sensible
subset.

Ciao,

Duncan.



More information about the llvm-commits mailing list