[llvm-commits] [llvm] r89639 - in /llvm/trunk: lib/Transforms/Scalar/InstructionCombining.cpp test/Transforms/InstCombine/compare-signs.ll

[Nick Lewycky]

Duncan Sands wrote:
> Hi Nick,
>
>> + if (KnownZeroLHS.countLeadingOnes() == BitWidth-1 &&
>> + KnownZeroRHS.countLeadingOnes() == BitWidth-1) {
>
> == -> >= :)

Nope, look again!

+        APInt TypeMask(APInt::getHighBitsSet(BitWidth, BitWidth-1));

Thus, it will never return a knownzero with all bits set. :)

Nick