[llvm-commits] [llvm] r89211 - /llvm/trunk/CMakeLists.txt

[Óscar Fuentes]

Daniel Dunbar <daniel at zuster.org> writes:

>> One compromise that we can easily implement (at least on the cmake
>> build) is to default to OFF when building from a svn checkout and ON
>> otherwise. What do you think?
>
> I would rather change it in releases, since we already make this
> distinction in version tags. And I'm not actually yet convinced it is
> even the right default. Imagine we have tons and tons of examples, do
> I as a newbie want them all to be built? Probably not, I'd rather get
> the build done, and go type make in examples/TheOneThingIAmInterested
> in.

Right now, on the cmake build, this is not possible, as
LLVM_BUILD_EXAMPLES=OFF turns off the generation of targets
(i.e. makefiles) for that part of the source tree.

The fix is easy, though, and consists on adding EXCLUDE_FROM_ALL to the
add_executable that is invoked by add_llvm_executable when it is called
from add_llvm_example.

Hmmm, I think I'll implement that for add_llvm_tool too. Usually I'm
just interested on the libraries and set LLVM_BUILD_TOOLS to OFF but
sometimes I need some specific tool (opt and llvm-as, typically) and
this would save a reconfigure.

-- 
Óscar