[llvm-commits] [llvm] r88910 - /llvm/trunk/lib/VMCore/Core.cpp

[Nick Lewycky]

Duncan Sands wrote:
> Author: baldrick
> Date: Mon Nov 16 07:15:28 2009
> New Revision: 88910
>
> URL: http://llvm.org/viewvc/llvm-project?rev=88910&view=rev
> Log:
> BuildIntCast takes an additional parameter, isSigned.

That's not right. include/llvm-c/Core.h says:

   LLVMValueRef LLVMBuildIntCast(LLVMBuilderRef, LLVMValueRef Val,
                                 LLVMTypeRef DestTy, const char *Name);


Also, this is the C API, so you can't fix this by changing the signature 
on the C function, if it's ever been through a release.

This is breaking make check with the Ocaml bindings:

FAIL: /home/nicholas/llvm-commit/test/Bindings/Ocaml/analysis.ml
Failed with exit(2) at line 1
while running: /usr/bin/ocamlopt -cc "g++ -Wall -D_FILE_OFFSET_BITS=64 
-D_REENTRANT" -I /home/nicholas/llvm-commit/Debug/lib/ocaml -warn-error 
A llvm.cmxa llvm_analysis.cmxa 
/home/nicholas/llvm-commit/test/Bindings/Ocaml/analysis.ml -o 
analysis.ml.tmp
/usr/bin/ld: 
/home/nicholas/llvm-commit/Debug/lib/ocaml/libllvm.a(llvm_ocaml.o): in 
function llvm_build_intcast:llvm_ocaml.c:1388: error: undefined 
reference to 'LLVMBuildIntCast'
collect2: ld returned 1 exit status
File "caml_startup", line 1, characters 0-1:
Error: Error during linking

FAIL: /home/nicholas/llvm-commit/test/Bindings/Ocaml/bitreader.ml
Failed with exit(2) at line 1
while running: /usr/bin/ocamlopt -cc "g++ -Wall -D_FILE_OFFSET_BITS=64 
-D_REENTRANT" -I /home/nicholas/llvm-commit/Debug/lib/ocaml -warn-error 
A llvm.cmxa llvm_bitreader.cmxa llvm_bitwriter.cmxa 
/home/nicholas/llvm-commit/test/Bindings/Ocaml/bitreader.ml -o 
bitreader.ml.tmp
/usr/bin/ld: 
/home/nicholas/llvm-commit/Debug/lib/ocaml/libllvm.a(llvm_ocaml.o): in 
function llvm_build_intcast:llvm_ocaml.c:1388: error: undefined 
reference to 'LLVMBuildIntCast'
collect2: ld returned 1 exit status
File "caml_startup", line 1, characters 0-1:
Error: Error during linking

FAIL: /home/nicholas/llvm-commit/test/Bindings/Ocaml/bitwriter.ml
Failed with exit(2) at line 1
while running: /usr/bin/ocamlopt -cc "g++ -Wall -D_FILE_OFFSET_BITS=64 
-D_REENTRANT" -I /home/nicholas/llvm-commit/Debug/lib/ocaml -warn-error 
A llvm.cmxa llvm_bitwriter.cmxa 
/home/nicholas/llvm-commit/test/Bindings/Ocaml/bitwriter.ml -o 
bitwriter.ml.tmp
/usr/bin/ld: 
/home/nicholas/llvm-commit/Debug/lib/ocaml/libllvm.a(llvm_ocaml.o): in 
function llvm_build_intcast:llvm_ocaml.c:1388: error: undefined 
reference to 'LLVMBuildIntCast'
collect2: ld returned 1 exit status
File "caml_startup", line 1, characters 0-1:
Error: Error during linking

FAIL: /home/nicholas/llvm-commit/test/Bindings/Ocaml/executionengine.ml
Failed with exit(2) at line 1
while running: /usr/bin/ocamlopt -cc "g++ -Wall -D_FILE_OFFSET_BITS=64 
-D_REENTRANT" -I /home/nicholas/llvm-commit/Debug/lib/ocaml -warn-error 
A llvm.cmxa llvm_target.cmxa llvm_executionengine.cmxa 
/home/nicholas/llvm-commit/test/Bindings/Ocaml/executionengine.ml -o 
executionengine.ml.tmp
/usr/bin/ld: 
/home/nicholas/llvm-commit/Debug/lib/ocaml/libllvm.a(llvm_ocaml.o): in 
function llvm_build_intcast:llvm_ocaml.c:1388: error: undefined 
reference to 'LLVMBuildIntCast'
collect2: ld returned 1 exit status
File "caml_startup", line 1, characters 0-1:
Error: Error during linking

FAIL: /home/nicholas/llvm-commit/test/Bindings/Ocaml/scalar_opts.ml
Failed with exit(2) at line 1
while running: /usr/bin/ocamlopt -cc "g++ -Wall -D_FILE_OFFSET_BITS=64 
-D_REENTRANT" -I /home/nicholas/llvm-commit/Debug/lib/ocaml -warn-error 
A llvm.cmxa llvm_scalar_opts.cmxa llvm_target.cmxa 
/home/nicholas/llvm-commit/test/Bindings/Ocaml/scalar_opts.ml -o 
scalar_opts.ml.tmp
/usr/bin/ld: 
/home/nicholas/llvm-commit/Debug/lib/ocaml/libllvm.a(llvm_ocaml.o): in 
function llvm_build_intcast:llvm_ocaml.c:1388: error: undefined 
reference to 'LLVMBuildIntCast'
collect2: ld returned 1 exit status
File "caml_startup", line 1, characters 0-1:
Error: Error during linking

FAIL: /home/nicholas/llvm-commit/test/Bindings/Ocaml/target.ml
Failed with exit(2) at line 1
while running: /usr/bin/ocamlopt -cc "g++ -Wall -D_FILE_OFFSET_BITS=64 
-D_REENTRANT" -I /home/nicholas/llvm-commit/Debug/lib/ocaml -warn-error 
A llvm.cmxa llvm_target.cmxa 
/home/nicholas/llvm-commit/test/Bindings/Ocaml/target.ml -o target.ml.tmp
/usr/bin/ld: 
/home/nicholas/llvm-commit/Debug/lib/ocaml/libllvm.a(llvm_ocaml.o): in 
function llvm_build_intcast:llvm_ocaml.c:1388: error: undefined 
reference to 'LLVMBuildIntCast'
collect2: ld returned 1 exit status
File "caml_startup", line 1, characters 0-1:
Error: Error during linking

FAIL: /home/nicholas/llvm-commit/test/Bindings/Ocaml/vmcore.ml
Failed with exit(2) at line 1
while running: /usr/bin/ocamlopt -cc "g++ -Wall -D_FILE_OFFSET_BITS=64 
-D_REENTRANT" -I /home/nicholas/llvm-commit/Debug/lib/ocaml -warn-error 
A llvm.cmxa llvm_analysis.cmxa llvm_bitwriter.cmxa 
/home/nicholas/llvm-commit/test/Bindings/Ocaml/vmcore.ml -o vmcore.ml.tmp
/usr/bin/ld: 
/home/nicholas/llvm-commit/Debug/lib/ocaml/libllvm.a(llvm_ocaml.o): in 
function llvm_build_intcast:llvm_ocaml.c:1388: error: undefined 
reference to 'LLVMBuildIntCast'
collect2: ld returned 1 exit status
File "caml_startup", line 1, characters 0-1:
Error: Error during linking

Nick

> Modified:
>      llvm/trunk/lib/VMCore/Core.cpp
>
> Modified: llvm/trunk/lib/VMCore/Core.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/VMCore/Core.cpp?rev=88910&r1=88909&r2=88910&view=diff
>
> ==============================================================================
> --- llvm/trunk/lib/VMCore/Core.cpp (original)
> +++ llvm/trunk/lib/VMCore/Core.cpp Mon Nov 16 07:15:28 2009
> @@ -1860,8 +1860,9 @@
>   }
>
>   LLVMValueRef LLVMBuildIntCast(LLVMBuilderRef B, LLVMValueRef Val,
> -                              LLVMTypeRef DestTy, const char *Name) {
> -  return wrap(unwrap(B)->CreateIntCast(unwrap(Val), unwrap(DestTy), Name));
> +                              LLVMTypeRef DestTy, int isSigned,
> +                              const char *Name) {
> +  return wrap(unwrap(B)->CreateIntCast(unwrap(Val), unwrap(DestTy), isSigned, Name));
>   }
>
>   LLVMValueRef LLVMBuildFPCast(LLVMBuilderRef B, LLVMValueRef Val,
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>