[llvm-commits] [llvm] r88979 - /llvm/trunk/Makefile

[Daniel Dunbar]

On Mon, Nov 16, 2009 at 11:54 PM, Duncan Sands <baldrick at free.fr> wrote:
> Hi Daniel,
>
>> Don't build examples by default, use BUILD_EXAMPLES=1 to build them. The
>> only utility of this is testing that we keep the examples up to date, I will
>> just make the buildbots run with this flag.
>
> is this really a good idea?

Yes, I think so. I don't think the examples break that often.
Additionally, developers changing APIs widely are already probably
using grep or other tools to find the code to fix, and can always test
the examples directly.

>  If someone breaks an example, wouldn't it be
> better
> for them to discover that directly themselves rather than via a buildbot?

No, this optimizes for the rare case (single developer, breaking
single build) at the expensive of the extraordinarily common case
(many many developers and buildbots, rebuilding llvm).

>  And
> what about newcomers who want to build examples - aren't they going to have
> a
> hard time working out how to build the examples?

Probably not, I think its pretty common to have optional code that
isn't built by default. Frequently located in the examples directory.
I'll add some more docs if you think I should and point me to where
you would like them.

Also viable would be to change this setting for releases.

 - Daniel

> Ciao,
>
> Duncan.
>