[llvm-commits] [llvm] r89523 - /llvm/trunk/lib/Transforms/Scalar/SimplifyLibCalls.cpp

[Eric Christopher]

On Nov 20, 2009, at 11:58 PM, Duncan Sands wrote:

> Hi Eric,
> 
>> +  Optimizations["llvm.objectsize.i32"] = &ObjectSize;
>> +  Optimizations["llvm.objectsize.i64"] = &ObjectSize;
> 
> these are not libcalls, they are llvm intrinsics.  Why not just
> simplify them in instcombine?

I'm not sure, ultimately, how it's going to come out and right now this keeps it all in one area. (i.e. I'm not sure if object size is going to be its own pass or whether instcombine is fine, or...)

> PS: do you need to check the prototype here, or is it guaranteed to be correct
> since this is an intrinsic? 

Guaranteed since it is an intrinsic afaik.

-eric