[llvm-commits] [PATCH] LTO code generator options

[Rafael Espindola]

2009/11/17 Viktor Kutuzov <vkutuzov at accesssoftek.com>:
> Thanks for reviewing it, Rafael.
>
> Now while we are both on the same waive, let's go with the rest of the patches.

Have you committed the previous one?

> I have tried to combine them on the same manner as the last one.

Thanks!

You have

+        const std::string FeatureStr =
+            SubtargetFeatures::getDefaultSubtargetFeatures(Triple.c_str());

But getDefaultSubtargetFeatures takes a triple. You have to change the
.c_str() to llvm::Triple().

I think the patch is OK with that change. Nick, can you just comment
on lib/Target/SubtargetFeature.cpp being the right place to put this?
I think it is, but I am not as familiar with this code.

> The attached patch has similar OS and Vendor independent re-factoring for Subtarget features (attributes).
>
> I moved Applce-specific code from tools/lto/LTOModule.cpp to lib/Target/SubtargetFeature.cpp with related header files update.
>
> Cheers,
> Viktor.
>

Cheers,

-- 
Rafael Ávila de Espíndola