[llvm-commits] [llvm] r88902 - /llvm/trunk/lib/VMCore/AsmWriter.cpp

Evan Cheng evan.cheng at apple.com
Mon Nov 16 11:44:56 PST 2009


On Nov 16, 2009, at 7:17 AM, David Greene wrote:

> On Monday 16 November 2009 01:10, Evan Cheng wrote:
>> Author: evancheng
>> Date: Mon Nov 16 01:10:36 2009
>> New Revision: 88902
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=88902&view=rev
>> Log:
>> Special case FixedStackPseudoSourceValueVal as well. Do we really need to
>> differentiate PseudoSourceValueVal from FixedStackPseudoSourceValueVal at
>> this level?
> 
> Yes.  The asm printer uses it to emit comments about spills.
> 
>                                   -Dave

That's not quite what I am asking. Your change introduced a new Value type for a very specialized sub-type of PseudoSourceValueVal at llvm IR level. Are you sure there isn't another way to handle it?

Evan



More information about the llvm-commits mailing list