[llvm-commits] move CPU detection from lib/Target/$FOO to libSystem

[Chandler Carruth]

On Fri, Nov 13, 2009 at 3:48 AM, Roman Divacky <rdivacky at freebsd.org> wrote:
> hi
>
> the attached patch moves cpu detection code from lib/Target/$FOO
> (for FOO=X86 :) ) to lib/System. This is necessary for clang
> to be able to do -march=native. The patch was already reviewed
> by Daniel Dunbar.
>
> Can you please review/commit this?

A meta-point: you're moving a lot more than just GetCurrentX86CPU into
libSystem, can you expose the other functions and delete the copies in
X86Subtarget? I'd rather avoid duplicating subtle code like that.

Also, why add the include on StringMap?

>
> thnx!
>
> roman
>
> p.s. CC: me as I am not subscribed to llvm-commits
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>