[llvm-commits] [llvm] r87047 - in /llvm/trunk: include/llvm/Target/TargetInstrInfo.h lib/Target/X86/X86InstrInfo.cpp lib/Target/X86/X86InstrInfo.h

[Bill Wendling]

On Nov 12, 2009, at 4:34 PM, David Greene wrote:

> On Thursday 12 November 2009 18:30, Bill Wendling wrote:
>> On Nov 12, 2009, at 4:29 PM, David Greene wrote:
>>> Author: greened
>>> Date: Thu Nov 12 18:29:53 2009
>>> New Revision: 87047
>>>
>>> URL: http://llvm.org/viewvc/llvm-project?rev=87047&view=rev
>>> Log:
>>>
>>> Fix a bootstrap failure.
>>>
>>> Provide special isLoadFromStackSlotPostFE and  
>>> isStoreToStackSlotPostFE
>>> interfaces to explicitly request checking for post-frame ptr
>>> elimination
>>> operands.  This uses a heuristic so it isn't reliable for  
>>> correctness.
>>
>> What do you mean it isn't reliable for correctness?! How is this
>> actually fixing anything then?
>
> Because it's only being used for comments at the moment and those  
> don't
> need to be 100% correct (though it would be nice).
>
This makes no sense to me. What do you mean "comments"? What comments?

I'm not happy with the state of affairs. The build bots have been  
broken all day. Unless you can say that this patch fixes the *real*  
problem with the bootstrap, and not some "comment" that isn't  
"reliable" for correctness, then I'll be reverting all of your work  
today.

-bw