[llvm-commits] [PATCH] Make X86-64 in the Large model always emit 64-bit calls

[Dan Gohman]

On Nov 12, 2009, at 11:19 AM, jyasskin at gmail.com wrote:

> Reviewers: gohman_apple.com,
> 
> Message:
> Patch at http://codereview.appspot.com/download/issue154066_1033.diff
> 
> I'm unfamiliar with the code generator, so please go over that part of
> the change with a fine-toothed comb.

In the X86ISelLowering.cpp part, disabling the special handling
for GlobalAddresses and ExternalSymbols is fine, but the way the
proposed patch does that also happens to disable the 
"else if (isTailCall)" code immediately below that, which handles
indirect tail calls. That code is still needed in the large code
model -- the callee needs to be in a specific physical register
so that it can survive the epilogue.

I'm not familiar enough with JIT stubs to comment on the rest
of the patch.

Dan