[llvm-commits] [zorg] r86693 - /zorg/trunk/zorg/buildbot/util/InformativeMailNotifier.py

Daniel Dunbar daniel at zuster.org
Tue Nov 10 10:21:22 PST 2009


Author: ddunbar
Date: Tue Nov 10 12:21:22 2009
New Revision: 86693

URL: http://llvm.org/viewvc/llvm-project?rev=86693&view=rev
Log:
Fix bug in InformativeMailNotifier compare routine that ended up comapring a bound method, which led to an infinite loop.

Modified:
    zorg/trunk/zorg/buildbot/util/InformativeMailNotifier.py

Modified: zorg/trunk/zorg/buildbot/util/InformativeMailNotifier.py
URL: http://llvm.org/viewvc/llvm-project/zorg/trunk/zorg/buildbot/util/InformativeMailNotifier.py?rev=86693&r1=86692&r2=86693&view=diff

==============================================================================
--- zorg/trunk/zorg/buildbot/util/InformativeMailNotifier.py (original)
+++ zorg/trunk/zorg/buildbot/util/InformativeMailNotifier.py Tue Nov 10 12:21:22 2009
@@ -10,6 +10,10 @@
     compare_attrs = (mail.MailNotifier.compare_attrs +
                      ["num_lines", "only_failure_logs"])
 
+    # Remove customMesg from the compare_attrs, that would lead to
+    # recursion, and is checked by the class test.
+    compare_attrs.remove("customMesg")
+
     # FIXME: The customMessage interface is fairly inefficient, switch to
     # something new when it becomes available.
 





More information about the llvm-commits mailing list