[llvm-commits] [llvm] r86428 - in /llvm/trunk: lib/ExecutionEngine/Interpreter/Execution.cpp test/ExecutionEngine/interpreter-ext.ll
Nick Lewycky
nicholas at mxc.ca
Sat Nov 7 16:45:29 PST 2009
Author: nicholas
Date: Sat Nov 7 18:45:29 2009
New Revision: 86428
URL: http://llvm.org/viewvc/llvm-project?rev=86428&view=rev
Log:
Fix the interpreter to not crash due to zeroext/signext
Added:
llvm/trunk/test/ExecutionEngine/interpreter-ext.ll
Modified:
llvm/trunk/lib/ExecutionEngine/Interpreter/Execution.cpp
Modified: llvm/trunk/lib/ExecutionEngine/Interpreter/Execution.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/ExecutionEngine/Interpreter/Execution.cpp?rev=86428&r1=86427&r2=86428&view=diff
==============================================================================
--- llvm/trunk/lib/ExecutionEngine/Interpreter/Execution.cpp (original)
+++ llvm/trunk/lib/ExecutionEngine/Interpreter/Execution.cpp Sat Nov 7 18:45:29 2009
@@ -882,16 +882,6 @@
e = SF.Caller.arg_end(); i != e; ++i, ++pNum) {
Value *V = *i;
ArgVals.push_back(getOperandValue(V, SF));
- // Promote all integral types whose size is < sizeof(i32) into i32.
- // We do this by zero or sign extending the value as appropriate
- // according to the parameter attributes
- const Type *Ty = V->getType();
- if (Ty->isInteger() && (ArgVals.back().IntVal.getBitWidth() < 32)) {
- if (CS.paramHasAttr(pNum, Attribute::ZExt))
- ArgVals.back().IntVal = ArgVals.back().IntVal.zext(32);
- else if (CS.paramHasAttr(pNum, Attribute::SExt))
- ArgVals.back().IntVal = ArgVals.back().IntVal.sext(32);
- }
}
// To handle indirect calls, we must get the pointer value from the argument
Added: llvm/trunk/test/ExecutionEngine/interpreter-ext.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/ExecutionEngine/interpreter-ext.ll?rev=86428&view=auto
==============================================================================
--- llvm/trunk/test/ExecutionEngine/interpreter-ext.ll (added)
+++ llvm/trunk/test/ExecutionEngine/interpreter-ext.ll Sat Nov 7 18:45:29 2009
@@ -0,0 +1,19 @@
+; RUN: lli -force-interpreter
+; Extending a value due to zeroext/signext will leave it the wrong size
+; causing problems later, such as a crash if you try to extend it again.
+
+define void @zero(i8 zeroext %foo) {
+ zext i8 %foo to i32
+ ret void
+}
+
+define void @sign(i8 signext %foo) {
+ sext i8 %foo to i32
+ ret void
+}
+
+define i32 @main() {
+ call void @zero(i8 0)
+ call void @sign(i8 0)
+ ret i32 0
+}
More information about the llvm-commits
mailing list