[llvm-commits] [PATCH] Make the need-stub variables accurate and consistent

[jyasskin at gmail.com]

Reviewers: ,

Message:
Please take a look.

I'd like to find an example of a global-variable far stub to put in the
comment for MachineRelocation::mayNeedFarStub(). Can anyone describe the
requirement for ARM or another platform so I can copy it in?

Description:
I'm trying to tease apart the different uses for "stubs" in the JIT. In
the case of MachineRelocations, I believe "stub" always refers to a
far-call stub or a load-a-faraway-global stub, so this patch adds "Far"
to the term. The variable was also inconsistent between the positive and
negative sense, and the positive sense ("NeedStub") was more demanding
than is accurate (since a nearby-enough function can be called directly
even if the platform often requires a stub). Since the negative sense
causes double-negatives, I switched to "MayNeedFarStub" globally.

Please review this at http://codereview.appspot.com/151051

Affected files:
   M include/llvm/CodeGen/MachineRelocation.h
   M lib/ExecutionEngine/JIT/JITEmitter.cpp
   M lib/Target/ARM/ARMCodeEmitter.cpp
   M lib/Target/X86/X86CodeEmitter.cpp