[llvm-commits] [PATCH] At beginning of SelectionDAGISel::LowerArguments, see if return values can be lowered to registers

[Kenneth Uildriks]

On Fri, Nov 6, 2009 at 7:17 PM, Dan Gohman <gohman at apple.com> wrote:
> Hello,
>
> This looks good to me, though please use spaces instead of tabs for
> indentation.

I thought I did.  Sometimes my editor is too smart for its own good.
I'll fix it before I check it in.

>
> It would be cool if we could find a way to implement CanLowerReturn
> without using target-specific code, since it doesn't have very much
> target-specific logic in it, but I'm fine leaving this as it is
> for now.

I'd love to pull that off too, but like
LowerReturn/AnalyzeReturnValues, it needs the assign callback.  It
could probably be tablegen'd somehow, since it doesn't have to do any
actual register assignments afterwards.

When I finish the automatic sret-demotion, I'll need some help to test
it on various targets... all I've got is an X86.

Thanks for looking at it.