[llvm-commits] [llvm] r85922 - /llvm/trunk/lib/Support/MemoryBuffer.cpp

Duncan Sands baldrick at free.fr
Wed Nov 4 12:50:58 PST 2009


Hi Dan,

>> if errno is EINTR, isn't it correct to go around again, even if zero bytes
>> were read?
> 
> read could return 0 and leave errno unmodified. errno could be set to
> EINTR by unrelated code before the first read call. If read keeps
> returning 0 for some reason, the code wouldn't recover.

fair enough.  Fixed in commit 86046.

Ciao,

Duncan.



More information about the llvm-commits mailing list