[llvm-commits] [llvm] r85980 - /llvm/trunk/lib/Target/ARM/ARMInstrThumb.td

[Sandeep Patel]

ccOyyiCD.s:214: Error: bad instruction `ldr.nhi r1,.LCPI3_1'

while building _gcov.c for the thumb multilib.

We're working on a buildbot.

deep

On Wed, Nov 4, 2009 at 3:24 AM, Bob Wilson <bob.wilson at apple.com> wrote:
> How?  testcase, etc....
>
> On Nov 3, 2009, at 7:13 PM, Sandeep Patel wrote:
>
>> This broke arm-eabi.
>>
>> deep
>>
>> On Wed, Nov 4, 2009 at 12:00 AM, Evan Cheng <evan.cheng at apple.com> wrote:
>>> Author: evancheng
>>> Date: Tue Nov  3 18:00:39 2009
>>> New Revision: 85980
>>>
>>> URL: http://llvm.org/viewvc/llvm-project?rev=85980&view=rev
>>> Log:
>>> Use ldr.n to workaround a darwin assembler bug.
>>>
>>> Modified:
>>>    llvm/trunk/lib/Target/ARM/ARMInstrThumb.td
>>>
>>> Modified: llvm/trunk/lib/Target/ARM/ARMInstrThumb.td
>>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/ARM/ARMInstrThumb.td?rev=85980&r1=85979&r2=85980&view=diff
>>>
>>> ==============================================================================
>>> --- llvm/trunk/lib/Target/ARM/ARMInstrThumb.td (original)
>>> +++ llvm/trunk/lib/Target/ARM/ARMInstrThumb.td Tue Nov  3 18:00:39 2009
>>> @@ -326,9 +326,10 @@
>>>                     "ldr", "\t$dst, $addr", []>;
>>>
>>>  // Load tconstpool
>>> +// FIXME: Use ldr.n to work around a Darwin assembler bug.
>>>  let canFoldAsLoad = 1 in
>>>  def tLDRpci : T1pIs<(outs tGPR:$dst), (ins i32imm:$addr), IIC_iLoadi,
>>> -                  "ldr", "\t$dst, $addr",
>>> +                  "ldr.n", "\t$dst, $addr",
>>>                   [(set tGPR:$dst, (load (ARMWrapper tconstpool:$addr)))]>;
>>>
>>>  // Special LDR for loads from non-pc-relative constpools.
>>>
>>>
>>> _______________________________________________
>>> llvm-commits mailing list
>>> llvm-commits at cs.uiuc.edu
>>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>