[llvm-commits] [llvm-gcc-4.2] r85835 - in /llvm-gcc-4.2/trunk/gcc: llvm-convert.cpp llvm-internal.h

Bob Wilson bob.wilson at apple.com
Tue Nov 3 08:33:24 PST 2009


On Nov 3, 2009, at 3:11 AM, Duncan Sands wrote:

> Hi Bob, thanks for doing this.
>
>> +Constant *TreeToLLVM::EmitLV_LABEL_DECL(tree exp) {
>> +  // GCC kindly diverts labels for unreachable basic blocks to  
>> reachable blocks,
>> +  // so we are not obliged to output unreachable blocks even if  
>> the original
>> +  // code took the address of one.
>
> this comment is only really relevant to dragonegg, which outputs  
> basic basic
> blocks in dom order (in order to translate phi nodes), and as a side- 
> effect
> only outputs reachable basic blocks.

OK.  I removed it.  Thanks for the review.



More information about the llvm-commits mailing list