[llvm-commits] [llvm] r85728 - in /llvm/trunk: include/llvm/TypeSymbolTable.h lib/Transforms/Scalar/SimplifyCFGPass.cpp lib/VMCore/Constants.cpp lib/VMCore/ConstantsContext.h lib/VMCore/LLVMContextImpl.h lib/VMCore/LeakDetector.cpp lib/VMCore/LeaksContext.h lib/VMCore/Type.cpp lib/VMCore/TypeSymbolTable.cpp lib/VMCore/Value.cpp

[Owen Anderson]

Chris,

On Nov 1, 2009, at 10:42 AM, Chris Lattner wrote:

> Author: lattner
> Date: Sun Nov  1 12:42:03 2009
> New Revision: 85728
>
> URL: http://llvm.org/viewvc/llvm-project?rev=85728&view=rev
> Log:
> remove a bunch of locking from LLVMContextImpl.  Since only one thread
> can be banging on a context at a time, this isn't needed.  Owen,  
> please
> review.

I have one concern about this.  There are a few places in the codebase  
that still use the global context, because they're just creating  
sentinel objects, and it proved inconvenient to get a real context to  
them.  In these cases, you can have multiple threads accessing a  
single context.  Please grep through the codebase and ensure that each  
location that still uses the global context (should be able to just  
grep for getGlobalContext()) is doing its own locking, since the  
context itself no longer does.

--Owen
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 2620 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20091101/65e13e22/attachment.bin>