[llvm-commits] [patch] Fix ARM varg functions with 5 or more regular arguments

Evan Cheng evan.cheng at apple.com
Fri Oct 30 00:14:21 PDT 2009


Looks right to me. Test case please. :-)

Evan

On Oct 29, 2009, at 7:45 PM, Rafael Espindola wrote:

> The attached patch fixes functions like
>
> void f (int a1, int a2, int a3, int a4, int a5,...)
>
> In ARMTargetLowering::LowerFormalArguments if the function has 4 or
> more regular arguments we correctly don't save the r0-r3 registers on
> the stack. The problem is that we also set VarArgsFrameIndex using an
> offset of 0, which is only correct if the function has exactly 4
> regular arguments.
>
> Is the patch OK with a testcase? I promises to write one before  
> committing :-)
>
> Cheers,
> -- 
> Rafael Ávila de Espíndola
> <llvm-varg.patch>_______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits





More information about the llvm-commits mailing list