[llvm-commits] [llvm-gcc-4.2] r85407 - /llvm-gcc-4.2/trunk/gcc/llvm-convert.cpp

[Jim Grosbach]

Thanks, Dale!

-j

On Oct 28, 2009, at 10:38 AM, Dale Johannesen wrote:

> Author: johannes
> Date: Wed Oct 28 12:38:51 2009
> New Revision: 85407
>
> URL: http://llvm.org/viewvc/llvm-project?rev=85407&view=rev
> Log:
> Remove used-uninitialized warning.  Add an assert to
> make it clearer to humans there is no uninitialized use,
> but there's no way a compiler could figure it out.
>
>
> Modified:
>    llvm-gcc-4.2/trunk/gcc/llvm-convert.cpp
>
> Modified: llvm-gcc-4.2/trunk/gcc/llvm-convert.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm-gcc-4.2/trunk/gcc/llvm-convert.cpp?rev=85407&r1=85406&r2=85407&view=diff
>
> =
> =
> =
> =
> =
> =
> =
> =
> ======================================================================
> --- llvm-gcc-4.2/trunk/gcc/llvm-convert.cpp (original)
> +++ llvm-gcc-4.2/trunk/gcc/llvm-convert.cpp Wed Oct 28 12:38:51 2009
> @@ -7774,7 +7774,7 @@
>     uint64_t GCCFieldOffsetInBits = getFieldOffsetInBits(Field);
>     NextField = TREE_CHAIN(Field);
>
> -    uint64_t FieldSizeInBits;
> +    uint64_t FieldSizeInBits = 0;
>     if (DECL_SIZE(Field))
>       FieldSizeInBits = getInt64(DECL_SIZE(Field), true);
>     uint64_t ValueSizeInBits = Val->getType()->getPrimitiveSizeInBits 
> ();
> @@ -7803,6 +7803,7 @@
>       // Bitfields can only be initialized with constants (integer  
> constant
>       // expressions).
>       assert(ValC);
> +      assert(DECL_SIZE(Field));
>       assert(ValueSizeInBits >= FieldSizeInBits &&
>              "disagreement between LLVM and GCC on bitfield size");
>       if (ValueSizeInBits != FieldSizeInBits) {
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits