[llvm-commits] [llvm] r85141 - /llvm/trunk/include/llvm/CodeGen/AntiDepBreaker.h

[Bill Wendling]

Thanks! :-)

-bw

On Oct 26, 2009, at 12:41 PM, David Goodwin wrote:

> Sending        include/llvm/CodeGen/AntiDepBreaker.h
> Sending        lib/CodeGen/PostRASchedulerList.cpp
> Transmitting file data ..
> Committed revision 85146.
>
> On Oct 26, 2009, at 12:07 PM, Bill Wendling wrote:
>
>> On Oct 26, 2009, at 12:00 PM, David Goodwin wrote:
>>
>>> Author: david_goodwin
>>> Date: Mon Oct 26 14:00:47 2009
>>> New Revision: 85141
>>>
>>> URL: http://llvm.org/viewvc/llvm-project?rev=85141&view=rev
>>> Log:
>>> Add virtual destructor.
>>>
>>> Modified:
>>>  llvm/trunk/include/llvm/CodeGen/AntiDepBreaker.h
>>>
>>> Modified: llvm/trunk/include/llvm/CodeGen/AntiDepBreaker.h
>>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/CodeGen/AntiDepBreaker.h?rev=85141&r1=85140&r2=85141&view=diff
>>>
>>> =
>>> =
>>> =
>>> =
>>> =
>>> =
>>> =
>>> =
>>> =
>>> =
>>> ====================================================================
>>> --- llvm/trunk/include/llvm/CodeGen/AntiDepBreaker.h (original)
>>> +++ llvm/trunk/include/llvm/CodeGen/AntiDepBreaker.h Mon Oct 26  
>>> 14:00:47 2009
>>> @@ -29,6 +29,8 @@
>>> /// anti-dependencies.
>>> class AntiDepBreaker {
>>> public:
>>> +  virtual ~AntiDepBreaker() { };
>>> +
>>
>> It's good to have the definition of a virtual destructor in  
>> the .cpp file. It "anchors" the vtable.
>>
>> -bw
>>
>