[llvm-commits] [llvm] r84130 - in /llvm/trunk/include/llvm: ADT/DenseMapInfo.h CodeGen/ScheduleDAG.h ExecutionEngine/JITMemoryManager.h Metadata.h Operator.h Pass.h Support/CommandLine.h Support/raw_ostream.h

Eric Christopher echristo at apple.com
Thu Oct 22 13:04:07 PDT 2009


On Oct 22, 2009, at 11:00 AM, Bill Wendling wrote:

> 
> On Oct 14, 2009, at 2:00 PM, Eric Christopher wrote:
> 
>> 
>> On Oct 14, 2009, at 1:28 PM, Eric Christopher wrote:
>> 
>>> -  virtual raw_ostream &changeColor(enum Colors colors, bool
>>> bold=false,
>>> -                                   bool  bg=false) { return *this; }
>>> +  virtual raw_ostream &changeColor(enum Colors, bool, bool)
>>> { return *this; }
>> 
>> Yep. Clang build failure from this.  Fixing.  That'll teach me to
>> forget to copy clang over when I checkout a fresh llvm.
>> 
> It's allowed that you can do this:
> 
>  virtual raw_ostream &changeColor(enum Colors, bool = false, bool = false)
>   { return *this; }

Yup. Dan mentioned that one to me :)

-eric



More information about the llvm-commits mailing list