[llvm-commits] [llvm-gcc-4.2] r84829 - /llvm-gcc-4.2/trunk/gcc/llvm-convert.cpp

[Chris Lattner]

On Oct 22, 2009, at 2:38 AM, Duncan Sands wrote:

> Hi Chris,
>
>> add a somewhat despicable (but precendented) hack to fix PR4678 & rdar://7309675 
>> .
>
> this is awful.  Was there something wrong with Rafael's proposed  
> patch from the
> PR?


The two fixes take a different approach (as far as I understand it).   
The major difference is that I want the warning from instcombine when  
you do this in C:

void foo() {.}
  ... foo(4);  ...

but not when you do this in C++:

void foo(...) {.}
  ... foo(4);  ...

My understanding is that Rafael's patch won't produce a warning in the  
first case.

-Chris