[llvm-commits] [llvm] r84804 - in /llvm/trunk: include/llvm/Metadata.h lib/VMCore/Metadata.cpp

[Devang Patel]

Author: dpatel
Date: Wed Oct 21 19:10:15 2009
New Revision: 84804

URL: http://llvm.org/viewvc/llvm-project?rev=84804&view=rev
Log:
Remove meaningless const.
Pass StringRef by value.

Modified:
    llvm/trunk/include/llvm/Metadata.h
    llvm/trunk/lib/VMCore/Metadata.cpp

Modified: llvm/trunk/include/llvm/Metadata.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Metadata.h?rev=84804&r1=84803&r2=84804&view=diff

==============================================================================
--- llvm/trunk/include/llvm/Metadata.h (original)
+++ llvm/trunk/include/llvm/Metadata.h Wed Oct 21 19:10:15 2009
@@ -61,7 +61,7 @@
     : MetadataBase(Type::getMetadataTy(C), Value::MDStringVal), Str(begin, l) {}
 
 public:
-  static MDString *get(LLVMContext &Context, const StringRef &Str);
+  static MDString *get(LLVMContext &Context, StringRef Str);
   
   StringRef getString() const { return Str; }
 
@@ -256,14 +256,14 @@
 public:
   /// registerMDKind - Register a new metadata kind and return its ID.
   /// A metadata kind can be registered only once. 
-  unsigned registerMDKind(const StringRef Name);
+  unsigned registerMDKind(StringRef Name);
 
   /// getMDKind - Return metadata kind. If the requested metadata kind
   /// is not registered then return 0.
-  unsigned getMDKind(const StringRef Name) const;
+  unsigned getMDKind(StringRef Name) const;
 
   /// isValidName - Return true if Name is a valid custom metadata handler name.
-  static bool isValidName(const StringRef Name);
+  static bool isValidName(StringRef Name);
 
   /// getMD - Get the metadata of given kind attached to an Instruction.
   /// If the metadata is not found then return 0.

Modified: llvm/trunk/lib/VMCore/Metadata.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/VMCore/Metadata.cpp?rev=84804&r1=84803&r2=84804&view=diff

==============================================================================
--- llvm/trunk/lib/VMCore/Metadata.cpp (original)
+++ llvm/trunk/lib/VMCore/Metadata.cpp Wed Oct 21 19:10:15 2009
@@ -26,7 +26,7 @@
 //===----------------------------------------------------------------------===//
 // MDString implementation.
 //
-MDString *MDString::get(LLVMContext &Context, const StringRef &Str) {
+MDString *MDString::get(LLVMContext &Context, StringRef Str) {
   LLVMContextImpl *pImpl = Context.pImpl;
   StringMapEntry<MDString *> &Entry = 
     pImpl->MDStringCache.GetOrCreateValue(Str);
@@ -186,7 +186,7 @@
 
 /// registerMDKind - Register a new metadata kind and return its ID.
 /// A metadata kind can be registered only once. 
-unsigned MetadataContext::registerMDKind(const StringRef Name) {
+unsigned MetadataContext::registerMDKind(StringRef Name) {
   assert(isValidName(Name) && "Invalid custome metadata name!");
   unsigned Count = MDHandlerNames.size();
   assert(MDHandlerNames.count(Name) == 0 && "Already registered MDKind!");
@@ -194,7 +194,7 @@
 }
 
 /// isValidName - Return true if Name is a valid custom metadata handler name.
-bool MetadataContext::isValidName(const StringRef MDName) {
+bool MetadataContext::isValidName(StringRef MDName) {
   if (MDName.empty())
     return false;
 
@@ -211,7 +211,7 @@
 
 /// getMDKind - Return metadata kind. If the requested metadata kind
 /// is not registered then return 0.
-unsigned MetadataContext::getMDKind(const StringRef Name) const {
+unsigned MetadataContext::getMDKind(StringRef Name) const {
   StringMap<unsigned>::const_iterator I = MDHandlerNames.find(Name);
   if (I == MDHandlerNames.end()) {
     assert(isValidName(Name) && "Invalid custome metadata name!");