[llvm-commits] [llvm] r84790 - /llvm/trunk/lib/VMCore/Metadata.cpp

[Chris Lattner]

On Oct 21, 2009, at 3:55 PM, Benjamin Kramer wrote:

> Author: d0k
> Date: Wed Oct 21 17:55:51 2009
> New Revision: 84790
>
> URL: http://llvm.org/viewvc/llvm-project?rev=84790&view=rev
> Log:
> Simplify code. No intended functionality change.

Thanks Benjamin!
> +++ llvm/trunk/lib/VMCore/Metadata.cpp Wed Oct 21 17:55:51 2009
> @@ -259,23 +259,17 @@
>
> /// isValidName - Return true if Name is a valid custom metadata  
> handler name.
> bool MetadataContext::isValidName(const StringRef MDName) {
> -  const char *Name = MDName.data();
> -  if (!Name)
> +  if (MDName.empty())
>     return false;
>
> -  if (!isalpha(*Name))
> +  if (!isalpha(MDName[1]))

I think this should be [0] not [1].

-Chris

>     return false;
>
> -  unsigned Length = strlen(Name);
> -  unsigned Count = 1;
> -  ++Name;
> -  while (Name &&
> -         (isalnum(*Name) || *Name == '_' || *Name == '-' || *Name  
> == '.')) {
> -    ++Name;
> -    ++Count;
> +  for (StringRef::iterator I = MDName.begin() + 1, E =  
> MDName.end(); I != E;
> +       ++I) {
> +    if (!isalnum(*I) && *I != '_' && *I != '-' && *I != '.')
> +        return false;
>   }
> -  if (Length != Count)
> -    return false;
>   return true;
> }
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits