[llvm-commits] [llvm] r84327 - /llvm/trunk/lib/CodeGen/CodePlacementOpt.cpp

[Dan Gohman]

On Oct 19, 2009, at 5:22 AM, Daniel Dunbar wrote:

> On Sun, Oct 18, 2009 at 8:36 PM, Evan Cheng <evan.cheng at apple.com> wrote:
>> 
>> On Oct 17, 2009, at 10:44 AM, Chris Lattner wrote:
>> 
>>> 
>>> On Oct 17, 2009, at 2:33 AM, Daniel Dunbar wrote:
>>> 
>>>> Author: ddunbar
>>>> Date: Sat Oct 17 04:33:00 2009
>>>> New Revision: 84327
>>>> 
>>>> URL: http://llvm.org/viewvc/llvm-project?rev=84327&view=rev
>>>> Log:
>>>> Suppress -Asserts warning.
>>> 
>>> Despite the name, I think that AnalyzeBranch does mutate the code in
>>> some cases on some targets.  Is this true?
>>> 
>> 
>> Not in this case since AllowModify is false.
>> 
>> virtual bool AnalyzeBranch(MachineBasicBlock &MBB, MachineBasicBlock *&TBB,
>>                             MachineBasicBlock *&FBB,
>>                             SmallVectorImpl<MachineOperand> &Cond,
>>                             bool AllowModify = false) const {
> 
> Ok. Please put it back inside the assert if it doesn't do anything
> else and you don't want it called in a -Asserts build, I just wanted
> the build warning to go away.

We do want it called in a -Asserts build. It sets TBB, FBB, and Cond
(by-reference). If the current code "(void) B;" is sufficient to
avoid the warning, then it's fine.

Dan