[llvm-commits] PATCH: Additional DebugFactory methods

[Chris Lattner]

On Oct 5, 2009, at 10:48 PM, Talin wrote:

> The attached patch adds some additional convenience methods to  
> DebugFactory. Specifically, methods that take a uint64 for size,  
> alignment or offset, can now also take a Constant *. This is very  
> useful for target-independent frontends which can use things like  
> ConstantExpr::getSizeof(). I've been using this for about a week in  
> my own code and it seems to work fine,

Hi Talin,

Sorry for the delay, still getting caught up.  Please change this to  
use StringRef like the current DebugInfo.h methods do.

Devang, can you review this in more detail?

-Chris