[llvm-commits] [llvm] r84020 - in /llvm/trunk: include/llvm/InlineAsm.h lib/AsmParser/LLLexer.cpp lib/AsmParser/LLParser.cpp lib/AsmParser/LLToken.h lib/Bitcode/Reader/BitcodeReader.cpp lib/Bitcode/Writer/BitcodeWriter.cpp lib/VMCore/AsmWriter.cpp lib/VMCore/Core.cpp lib/VMCore/InlineAsm.cpp test/Assembler/msasm.ll

[Dale Johannesen]

On Oct 13, 2009, at 6:11 PM, Chris Lattner wrote:

>
> On Oct 13, 2009, at 1:46 PM, Dale Johannesen wrote:
>
>> Author: johannes
>> Date: Tue Oct 13 15:46:56 2009
>> New Revision: 84020
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=84020&view=rev
>> Log:
>> Add an "msasm" flag to inline asm as suggested in PR 5125.
>> A little ugliness is accepted to keep the binary file format
>> compatible.  No functional change yet.
>
> Hi Dale,
>
> In general I think that this is a great approach.  One concern I  
> have is that "is ms asm" doesn't tell me what the flag does.  Would  
> it be possible to name this something like "might be call" or  
> something that more accurately conveys the semantic effect of this?   
> I'd much prefer LangRef to have a concrete description of what it  
> does (like volatile) instead of saying "originally from an asm  
> block" which doesn't communicate what it does or when someone would  
> want to set it.


Sure, we could do that; my intent was that if any other semantic  
differences show up they can also key off this flag instead of adding  
a new one.  Someone would want to set it if their source uses asm  
blocks.
In any event I am not going to get to changing this before I disappear  
for a few days.