[llvm-commits] [llvm] r84009 - in /llvm/trunk: lib/Target/ARM/ARMISelDAGToDAG.cpp lib/Target/ARM/ARMInstrInfo.td lib/Target/ARM/ARMInstrThumb2.td test/CodeGen/ARM/sbfx.ll

[Bob Wilson]

On Oct 13, 2009, at 1:25 PM, Sandeep Patel wrote:

> On Tue, Oct 13, 2009 at 8:09 PM, Bob Wilson <bob.wilson at apple.com>  
> wrote:
>> Same thing here.  I guess this is just a matter of style, but I  
>> would just
>> put this in-line in the one place where it is used.  Also, the  
>> comments for
>> this function and the previous one are not doxygenated.
>
> I cribbed these helpers from the PPC target.


Oh, I see.  But, for PPC these get called from more places....  I  
would still be inclined to put the code in-line, but that's pretty  
subjective, so I'll leave it up to you.