[llvm-commits] [llvm] r83902 - /llvm/trunk/lib/Target/ARM/ARMConstantIslandPass.cpp

[Evan Cheng]

On Oct 12, 2009, at 2:54 PM, Dale Johannesen wrote:

> 
> On Oct 12, 2009, at 2:23 PMPDT, Bob Wilson wrote:
> 
>> Author: bwilson
>> Date: Mon Oct 12 16:23:15 2009
>> New Revision: 83902
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=83902&view=rev
>> Log:
>> Last week, ARMConstantIslandPass was failing to converge for the
>> MultiSource/Benchmarks/MiBench/automotive-susan test.  The failure has
>> since been masked by an unrelated change (just randomly), so I don't  
>> have
>> a testcase for this now.  Radar 7291928.
> 
> Thanks for tracking this down and fixing it.  The last person to hit  
> it was not so brave; can we get rid of 78377 now?

Why do we want to get rid of 78377?  Error out is always better than infinite looping. It's still theoretically possible there is another bug that can cause it not to converge.

Evan

> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits