[llvm-commits] [llvm] r83894 - /llvm/trunk/lib/Target/ARM/ARMConstantIslandPass.cpp

Bob Wilson bob.wilson at apple.com
Mon Oct 12 13:37:23 PDT 2009


Author: bwilson
Date: Mon Oct 12 15:37:23 2009
New Revision: 83894

URL: http://llvm.org/viewvc/llvm-project?rev=83894&view=rev
Log:
Remove redundant parameter.

Modified:
    llvm/trunk/lib/Target/ARM/ARMConstantIslandPass.cpp

Modified: llvm/trunk/lib/Target/ARM/ARMConstantIslandPass.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/ARM/ARMConstantIslandPass.cpp?rev=83894&r1=83893&r2=83894&view=diff

==============================================================================
--- llvm/trunk/lib/Target/ARM/ARMConstantIslandPass.cpp (original)
+++ llvm/trunk/lib/Target/ARM/ARMConstantIslandPass.cpp Mon Oct 12 15:37:23 2009
@@ -165,8 +165,7 @@
     int LookForExistingCPEntry(CPUser& U, unsigned UserOffset);
     bool LookForWater(CPUser&U, unsigned UserOffset,
                       MachineBasicBlock *&NewMBB);
-    MachineBasicBlock* AcceptWater(MachineBasicBlock *WaterBB,
-                                   water_iterator IP);
+    MachineBasicBlock *AcceptWater(water_iterator IP);
     void CreateNewWater(unsigned CPUserIndex, unsigned UserOffset,
                       MachineBasicBlock** NewMBB);
     bool HandleConstantPoolUser(MachineFunction &MF, unsigned CPUserIndex);
@@ -932,9 +931,8 @@
 }
 
 /// AcceptWater - Small amount of common code factored out of the following.
-
-MachineBasicBlock* ARMConstantIslands::AcceptWater(MachineBasicBlock *WaterBB,
-                                                   water_iterator IP) {
+///
+MachineBasicBlock *ARMConstantIslands::AcceptWater(water_iterator IP) {
   DEBUG(errs() << "found water in range\n");
   // Remove the original WaterList entry; we want subsequent
   // insertions in this vicinity to go after the one we're
@@ -942,7 +940,7 @@
   // of times we have to move the same CPE more than once.
   WaterList.erase(IP);
   // CPE goes before following block (NewMBB).
-  return next(MachineFunction::iterator(WaterBB));
+  return next(MachineFunction::iterator(*IP));
 }
 
 /// LookForWater - look for an existing entry in the WaterList in which
@@ -973,7 +971,7 @@
           IPThatWouldPad = IP;
         }
       } else {
-        NewMBB = AcceptWater(WaterBB, IP);
+        NewMBB = AcceptWater(IP);
         return true;
       }
     }
@@ -981,7 +979,7 @@
       break;
   }
   if (isThumb && WaterBBThatWouldPad) {
-    NewMBB = AcceptWater(WaterBBThatWouldPad, IPThatWouldPad);
+    NewMBB = AcceptWater(IPThatWouldPad);
     return true;
   }
   return false;





More information about the llvm-commits mailing list