[llvm-commits] patch: memory use markers

[Chris Lattner]

On Oct 12, 2009, at 11:44 AM, Nick Lewycky wrote:

> 2009/10/12 Dan Gohman <gohman at apple.com>
>
> On Oct 11, 2009, at 3:25 PM, Nick Lewycky wrote:
>
> > This patch adds memory use markers as described in http://nondot.org/sabre/LLVMNotes/MemoryUseMarkers.txt
> >  . The bulk of the patch makes it possible to have intrinsics which
> > return {}.
>
> Hi Nick,
>
> The use of {} here is clever, but I don't think it's correct. Since {}
> has
> no members, the set of values has exactly one element, which means
> that all values of type {} can be assumed to be equivalent. Please use
> something like opaque* instead.
>
> I brought that up with Chris much earlier on (since I would've had  
> this patch done a month ago were it not for the need to support {})  
> but he was adamant that {} was the correct type for these. I was  
> suggesting metadata type though; opaque types require a name in the  
> module.

Dan convinced me that {} was a bad way to go, lets use "{}*" instead,  
does that work for you?

-Chris
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20091012/b9e2c293/attachment.html>