[llvm-commits] [llvm] r83391 - /llvm/trunk/lib/Support/Triple.cpp

Chris Lattner clattner at apple.com
Tue Oct 6 14:05:31 PDT 2009

>> Jeffrey, I don't think this patch is safe.  Twines are constructed  
>> based on
>> temporaries.  I think taht the temporary returned by  
>> getVendorName() is
>> destroyed at the ";" and the twine refers to the dangling pointer.   
>> CAn you
>> just build up a temporary std::string instead?
> Oops. SmallString<64> it is. Collin, could you check that this still
> works around the gcc-4.0.3 bug?
> <fix_triple_again.patch>

FWIW, this patch looks great to me (for real this time ;-)


More information about the llvm-commits mailing list