[llvm-commits] [PATCH] Bug fix for comma-separated in CommandLine.cpp
clattner at apple.com
Tue Oct 6 10:10:23 PDT 2009
On Oct 6, 2009, at 9:15 AM, Nicolas Geoffray wrote:
> Dear all,
> This simple patch fixes a bug in the CommaSeparated option in
> CommandLine. The current code does the following:
> For an arg written like this: -myarg=foo,bar
> It does myarg.push_back("foo") and myargs.push_back("foo,bar").
> The patch fixes the issue. I'm not sure if it follows the logic of
> all options in CommandLine.cpp, so I refer to someone who better
> knows the code.
Yes, this was introduced by a relatively recent refactoring of that
code I did, please commit.
> Index: lib/Support/CommandLine.cpp
> --- lib/Support/CommandLine.cpp (revision 83305)
> +++ lib/Support/CommandLine.cpp (working copy)
> @@ -643,6 +643,7 @@
> // Check for another comma.
> Pos = Val.find(',');
> + Value = Val;
> // If this is a named positional argument, just remember that it
> is the
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
More information about the llvm-commits