[llvm-commits] [patch] Add a test for PR3043

[Jeffrey Yasskin]

On Mon, Oct 5, 2009 at 3:32 PM, Chris Lattner <clattner at apple.com> wrote:
>
> On Oct 3, 2009, at 6:56 PM, Jeffrey Yasskin wrote:
>
>> In fixing bugs around stubs, it would be nice to have tests for the
>> bugs that have already been fixed so I don't reopen them. Here's one
>> for http://llvm.org/bugs/show_bug.cgi?id=3043. Since it's my first
>> addition to the dejagnu test suite, I'd appreciate any stylistic
>> pointers. I tested the test by disabling r59265, and indeed the test
>> fails.
>>
>> Evan, could you write a test for the bug
>> http://llvm.org/viewvc/llvm-project?view=rev&revision=60822 fixed? My
>> current fix for PR5116 simply reverts that change, and I want to know
>> if I'm breaking something or if the original bug has now been fixed
>> some other way.
>
> This looks ok to me.  However, we really prefer to minimize the number of
> executable tests that are in llvm/test.  I understand that this is hard to
> impossible for JIT tests though.  Please try to aggregate them together into
> fewer larger tests.

Ah, ok. I'll rename this to stubs.ll and put all new stub-related
tests in there.