[llvm-commits] [llvm] r83058 - in /llvm/trunk: lib/Target/ARM/ARMLoadStoreOptimizer.cpp test/CodeGen/ARM/2009-09-28-LdStOptiBug.ll

Evan Cheng evan.cheng at apple.com
Tue Sep 29 00:07:30 PDT 2009


Author: evancheng
Date: Tue Sep 29 02:07:30 2009
New Revision: 83058

URL: http://llvm.org/viewvc/llvm-project?rev=83058&view=rev
Log:
Fix PR4687. Pre ARMv5te does not support ldrd / strd. Patch by John Tytgat.

Added:
    llvm/trunk/test/CodeGen/ARM/2009-09-28-LdStOptiBug.ll
Modified:
    llvm/trunk/lib/Target/ARM/ARMLoadStoreOptimizer.cpp

Modified: llvm/trunk/lib/Target/ARM/ARMLoadStoreOptimizer.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/ARM/ARMLoadStoreOptimizer.cpp?rev=83058&r1=83057&r2=83058&view=diff

==============================================================================
--- llvm/trunk/lib/Target/ARM/ARMLoadStoreOptimizer.cpp (original)
+++ llvm/trunk/lib/Target/ARM/ARMLoadStoreOptimizer.cpp Tue Sep 29 02:07:30 2009
@@ -1191,6 +1191,10 @@
                                           unsigned &PredReg,
                                           ARMCC::CondCodes &Pred,
                                           bool &isT2) {
+  // Make sure we're allowed to generate LDRD/STRD.
+  if (!STI->hasV5TEOps())
+    return false;
+
   // FIXME: FLDS / FSTS -> FLDD / FSTD
   unsigned Scale = 1;
   unsigned Opcode = Op0->getOpcode();

Added: llvm/trunk/test/CodeGen/ARM/2009-09-28-LdStOptiBug.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/ARM/2009-09-28-LdStOptiBug.ll?rev=83058&view=auto

==============================================================================
--- llvm/trunk/test/CodeGen/ARM/2009-09-28-LdStOptiBug.ll (added)
+++ llvm/trunk/test/CodeGen/ARM/2009-09-28-LdStOptiBug.ll Tue Sep 29 02:07:30 2009
@@ -0,0 +1,19 @@
+; RUN: llc < %s -mtriple=armv5-unknown-linux-gnueabi -mcpu=arm10tdmi | FileCheck %s
+; PR4687
+
+%0 = type { double, double }
+
+define arm_aapcscc void @foo(%0* noalias nocapture sret %agg.result, double %x.0, double %y.0) nounwind {
+; CHECK: foo:
+; CHECK: bl __adddf3
+; CHECK-NOT: strd
+; CHECK: mov
+  %x76 = fmul double %y.0, 0.000000e+00           ; <double> [#uses=1]
+  %x77 = fadd double %y.0, 0.000000e+00           ; <double> [#uses=1]
+  %tmpr = fadd double %x.0, %x76                  ; <double> [#uses=1]
+  %agg.result.0 = getelementptr %0* %agg.result, i32 0, i32 0 ; <double*> [#uses=1]
+  store double %tmpr, double* %agg.result.0, align 8
+  %agg.result.1 = getelementptr %0* %agg.result, i32 0, i32 1 ; <double*> [#uses=1]
+  store double %x77, double* %agg.result.1, align 8
+  ret void
+}





More information about the llvm-commits mailing list